[17.0][IMP] payment_redsys: soporte para pre-autorización de cobro - #4205
[17.0][IMP] payment_redsys: soporte para pre-autorización de cobro#4205acysos wants to merge 2 commits into
Conversation
c3a9c12 to
c3ccb1c
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds pre-authorization support to the Redsys payment integration, enabling a two-step authorize-then-capture workflow.
- UI: Introduce “Authorize Amount” button and related fields on the payment form
- Documentation: Update configuration guides to cover transaction type 1 for pre-authorization
- Logic: Extend
account.paymentwith aredsys_authorize_amountmethod and new fields; register new view in manifest
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| views/account_payment_view.xml | Added button and fields for pre-authorization UI |
| readme/CONFIGURE.md & README.rst | Clarified transaction type “1” in setup docs |
| models/payment_provider.py | Enhanced redsys_transaction_type field with help |
| models/account_payment.py | Implemented pre-authorization logic and new fields |
| manifest.py | Included new view in module data |
Comments suppressed due to low confidence (2)
payment_redsys/models/account_payment.py:31
- Consider adding unit tests for
redsys_authorize_amountto cover success, validation errors, and error handling paths.
def redsys_authorize_amount(self):
payment_redsys/models/account_payment.py:59
- The transaction type is hardcoded to "2" instead of using
provider.redsys_transaction_type, causing mismatch between configuration and request.
"Ds_Merchant_TransactionType": "2",
862ffef to
b1bc47a
Compare
DarioLodeiros
left a comment
DarioLodeiros
left a comment
There was a problem hiding this comment.
Technical review Ok!
Functional: Review the visual elements related to the account.payment form confirmations so that they are only visible for payments that have an associated transaction with the provider Redsys of type 1.
b1bc47a to
e0b9002
Compare
Resuelto. |
7f0e14b to
6c2776b
Compare
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Gracias por la mejora, Ignacio. Todo el código añadido no tiene cobertura de test, lo que lo hace bastante frágil a posibles regresiones. ¿Podríais añadir código de test para cubrirlo?
pedrobaeza
changed the title
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
stale
2a19156 to
0a900a2
Compare
6e7850b to
cd58116
Compare
[IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro [IMP] payment_redsys: soporte para pre-autorización de cobro
cd58116 to
2b50b4f
Compare
|
Todos verdes. |
acysos
added
the
no stale
acysos
removed
the
no stale
|
@sergio-teruel podría echarle un ojo para intentar cerrarlo y subir el siguiente PR de redsys, que depende de este |
|
This PR has the |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
/ocabot merge minor
¿Puedes pasarlo a 18?
|
On my way to merge this fine PR! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-4205-by-pedrobaeza-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
| #, python-format | ||
| msgid "Redsys Auth done: %s" | ||
| msgstr "Cobro autorizado realizado: %s" | ||
| #: model:ir.model.fields,field_description:payment_redsys.field_payment_provider__redsys_currency |
Hola,
Implementación para añadir un nuevo tipo de operación. Este permite autorizar un cobro a una tarjeta pero no se cobra hasta que se ejecute luego en el pago. Esta función se utiliza cuando los pedidos online tienen un importe variable, por ejemplo, comprar en función del peso de fruta o verdura. Cuando se realiza una reserva y se cobra días antes de que se ejecute, por ejemplo, hoteles.
Saludos